[Documentation] [TitleIndex] [WordIndex

API review

Proposer: your name here

Present at review:

Question / concerns / comments

Enter your thoughts on the API and any questions / concerns you have here. Please sign your name. Anything you want to address in the API review should be marked down here before the start of the meeting.

Josh

enum DiagnosticLevel
{
  Level_OK = diagnostic_msgs::DiagnosticStatus::OK,
  Level_Warn = diagnostic_msgs::DiagnosticStatus::WARN,
  Level_Error = diagnostic_msgs::DiagnosticStatus::ERROR,
};

Comments to Josh

GenericAnalyzer can analyze messages that match the settings of its YAML file, or it can analyze the remainder. The aggregator node automatically makes an "Other" GenericAnalyzer to analyze any messages that haven't been looked at already.

StatusItem

Enum for Level

Public v. Private

Blaise

This is my first look at this. I basically wrote down all the whys that came to mind as I looked at this, so there are a lot of them. I'm not saying we have to change these, they are just the things I want to understand and discuss.

Meeting agenda

To be filled out by proposer based on comments gathered during API review period

Conclusion

bool match(name of item) const; // return whether or not analyze() should be called on this item
bool analyze(status item);  // happens as messages arrive on individual StatusItems. Return true to indicate that you have handled this message (rather than just observed it).
vector<> report(); // happens immediately before publish()

base_hk:
    name: Base Hokuyo
    start_name: base_hokuyo_node
    fields: 2



2020-10-10 12:32