[Documentation] [TitleIndex] [WordIndex

API review

Proposer: Josh Faust

Present at review:

See also:

Question / concerns / comments

Enter your thoughts on the API and any questions / concerns you have here. Please sign your name. Anything you want to address in the API review should be marked down here before the start of the meeting.

Eric

I had a number of questions, but they all got answered by the time I got to the end. This looks really nice and well thought-out to me.

Thoughts on the questions:

  1. SubscriptionMessageHelper doesn't seem like a uniquely good name. I would go ahead and implement the new ones with a different name, and deprecate the old versions, since that will let people play with the new system without breaking client libraries.

  2. Since we currently don't have any need for it, I'd push that off. Anyone who really needs it can write a custom serializer.
  3. default or standard serializer?
  4. For use in realtime that would definitely be nice to be able to do. Are boost shared pointers realtime safe?
    • [Josh]: The reference count is done atomically, so copying them is realtime safe. Their creation can be made realtime safe as well, since they support allocators
  5. No opinion

Brian

Like Eric, I had questions along the way, but they were pretty much all answered. Some that weren't:

On the questions:

  1. Agreed with Eric, if it's doable.
  2. Agreed with Eric.
  3. twoway, symmetric, bidirectional?

  4. If I template on an allocator type, I'd expect it to be used when I call or new or delete.

  5. The implemented solution looks good to me, but the use of event isn't obvious. What about adding a connection header turns a message into an event?

Josh

Meeting agenda

To be filled out by proposer based on comments gathered during API review period

Conclusion

Package status change mark change manifest)



2019-11-30 13:10